Tremulous Forum

General => Feedback => Topic started by: F50 on December 30, 2009, 09:27:48 pm

Title: Why is !revert and !buildlog resolved as won'tfix on the bugtracker?
Post by: F50 on December 30, 2009, 09:27:48 pm
Link (http://bugzilla.icculus.org/show_bug.cgi?id=3291)

If deconners can join, do damage, and leave (potentially with a ban), why shouldn't admins be able to undo that damage? I don't want this to be a whining thread (please, PLEASE lets *try* and keep this thread clean), but I would like to hear why this was rejected. What problem(s) would need to be solved to make this more likely to be committed? (theoretically speaking, idk if the problem(s) seem impossible to satisfy)

The article itself lists a few "issues" with !revert. Are these the reasons why it was listed as WONTFIX?

Quote
==== Issues ========
Reverts are irreversible: if an admin accidentally reverts an important
destruction or build, the action cannot be undone.
It is possible to abuse reversion and buildlog: if you suspect a move by the
enemy, you can use the log to choose a prime moment to attack or better still,
!revert the reactor away mid-build; if your own move runs into problems, simply
revert back to default base and all is well, and one more: 1) grab psaw 2) find
egg 3) saw 4) !revert 5) saw again 6) ??? 7) profit!
If a buildable is overwritten by a revert then its build remains logged and
cannot be reverted, preventing the reverting of any earlier events. This is a
bug.
Title: Re: Why is !revert and !buildlog resolved as won'tfix on the bugtracker?
Post by: SlackerLinux on December 31, 2009, 01:03:27 am
thats a  while back 2007 eh

i think abuse is a nonissue since its an ADMIN command and commands like ban and kick can be abused too

Rezyn has already ported revert to 1.2 so it isnt even any work for the devs to add it id also like some more of those patches commited like g_version and ban history changes or just a detailed explanation on why these and other useful admin commands are not being commited so any issues can be worked around to get those in there.
Title: Re: Why is !revert and !buildlog resolved as won'tfix on the bugtracker?
Post by: Taiyo.uk on December 31, 2009, 10:11:33 am
This sounds more like a matter of which admins are given access to the !buildlog and !revert commands, for the player this is a server choice issue. Deliberate abuse of these commands is commonplace in some servers and the modifications in that patch would not have stopped this. Accidental reverting of buildings is rare.
Title: Re: Why is !revert and !buildlog resolved as won'tfix on the bugtracker?
Post by: Undeference on December 31, 2009, 12:04:13 pm
F50, from your link
Quote
[reply] [-]   Comment 5    Ben Millwood      2007-11-18 09:14:09 EST

I've since released better versions of these commands but decided not to bother
keeping this bug up to date, since it's unlikely to be ever committed. Closed
so that (hopefully) people realise this is not the place from which to get the
patch.
afaik, it is more complex than is wanted and has only gotten more complex since.
Title: Re: Why is !revert and !buildlog resolved as won'tfix on the bugtracker?
Post by: UniqPhoeniX on December 31, 2009, 12:08:27 pm
Also: Buildlog is broken if used with more then 1 argument, and revert fails if a removed building was VERY close to another 1. But yes, abuse is a non-issue.
Title: Re: Why is !revert and !buildlog resolved as won'tfix on the bugtracker?
Post by: F50 on December 31, 2009, 11:09:30 pm
This sounds more like a matter of which admins are given access to the !buildlog and !revert commands

Ummm, no. Revert simply does not exist in svn trunk, and it has been stated that it will not exist, and I would like to know why that is, and what problems revert faces.

While potential abuse could be considered a problem, I'd prefer to assume that we can at very least trust some admins (server owner, devs, etc.) not to abuse this. Personally I think any admin that would abuse this command simply shouldn't be an admin in the first place, but that's just me.
Title: Re: Why is !revert and !buildlog resolved as won'tfix on the bugtracker?
Post by: bob0 on January 01, 2010, 12:45:35 am
http://tremulous.net/forum/index.php?topic=12579.msg185747#msg185747