Tremulous Forum

Mods => Modding Center => Topic started by: i3enedek on July 18, 2007, 09:04:12 pm

Title: How do you submit a patch?
Post by: i3enedek on July 18, 2007, 09:04:12 pm

There is a line in vm_ppc_new.c that came about with Apples switch to PowerPC, it makes sure that data in the instruction and data cache is synced after they moved away from the unified cache in the 601, anyway...

 // On Mac OS X, the following library routine clears the instruction cache for generated code
           MakeDataExecutable(vm->codeBase, vm->codeLength);

Spotted after I saw this in the Makefile;

    # Carbon is required on PPC only to make a call to MakeDataExecutable
    # in the PPC vm (should be a better non-Carbon way).
    #LDFLAGS += -framework Carbon

Well there is a better non-Carbon way;
msync( vm->codeBase, vm->codeLength, MS_INVALIDATE );

It compiles but im having trouble building the entire project since I updated to Quicktime 7.2.

ld: Undefined symbols:
_HIPointConvert referenced from QuickTime expected to be defined in Carbon
make[1]: *** [build/release-darwin-ppc/tremulous.ppc] Error 1
make: *** [build_release] Error 2

Probably to do with the bindings.

Title: How do you submit a patch?
Post by: tehOen on July 18, 2007, 09:21:47 pm

contact ioquake3 devs (zakk is mostly online)
#ioquake3 irc.freenode.net
edit:
also check the svn version it is updated (since tremulous is using ioquake3 engine you should check ioquake3 not tremulous)

Title: How do you submit a patch?
Post by: kevlarman on July 18, 2007, 09:29:09 pm

or ioq3 bugzilla (bugzilla.icculus.org), in general client/server changes go to ioq3 bugzilla and vm changes to tremulous bugzilla, any changes to the client/server that can't also be included in ioq3 tend to have a much lower chance of making it into svn.

Title: How do you submit a patch?
Post by: i3enedek on July 18, 2007, 11:51:27 pm

Ok it works but something is asking for a Gestalt ID so thats defo a legacy Carbon function, so until I find that the Carbon framework is still needed.

Title: How do you submit a patch?
Post by: tjw on July 19, 2007, 05:49:59 am

http://bugzilla.icculus.org/show_bug.cgi?id=3268

Title: How do you submit a patch?
Post by: i3enedek on July 19, 2007, 01:47:42 pm

Ahh well, this is terribly ironic.

Title: How do you submit a patch?
Post by: tjw on July 19, 2007, 04:02:57 pm

Quote from: "i3enedek"

Ahh well, this is terribly ironic.

Not really.  I just opened the bug in response to your posting ;)

Title: How do you submit a patch?
Post by: i3enedek on July 19, 2007, 05:41:51 pm

Quote from: "tjw"

Quote from: "i3enedek"

Ahh well, this is terribly ironic.

Not really.  I just opened the bug in response to your posting ;)

 :P

(and it is, as I file bugs all day long on Adobe apps and berate the other Engineers for not filing the bugs on the corporate DB).