Tremulous Forum

General => Feedback => Topic started by: imperiumZero on October 03, 2007, 03:33:50 am

Title: [SOLVED]Found Bug in r1020
Post by: imperiumZero on October 03, 2007, 03:33:50 am

I just went out and got 1020 and compiled it on my laptop with Benmachhine's 1024M backport patch.

While on SST I noticed that the names of players when they kill someone else carry over when there's another word or so after it.

So instead of

NoobOne was mauled by Rawr's Tyrant

It becomes:

NoobOne was mauled by Rawr's Tyrant

This applies to almost all messages that have a string _after_ the name, and therefor I believe it to be an error in resetting the string back to ^7 (white).

I'll post it on bugzilla later.

EDIT: On second thought this could be an issue due to SST being unpure. I'll check if Dretch*Storm does the same thing.

EDIT 2: This only happens on unpure servers.

Title: [SOLVED]Found Bug in r1020
Post by: imperiumZero on October 03, 2007, 04:00:22 am

May have found the problem:

On line 197 of cg_event.c:

Code: [Select]


  else
  {
    Q_strncpyz( attackerName, Info_ValueForKey( attackerInfo, "n" ), sizeof( attackerName ));
+    strcat( attackerName, S_COLOR_WHITE );
    // check for kill messages about the current clientNum
    if( target == cg.snap->ps.clientNum )
      Q_strncpyz( cg.killerName, attackerName, sizeof( cg.killerName ) );
  }


The strcat that adds the ^7 string is missing in 1020.

EDIT: Yep, that fixes it. It's on unpure servers only, but this does fix it.

Title: [SOLVED]Found Bug in r1020
Post by: Steely Ann on October 03, 2007, 04:28:20 am

Quote from: "imperiumZero"

It's ann unpure servers only, but this does fix it.

Don't drag me into this, you swine! :P

// The slashies, they tremble with rage.

Title: [SOLVED]Found Bug in r1020
Post by: imperiumZero on October 03, 2007, 04:31:43 am

@Reported to bugzilla...


@Steely Ann ...no I mis-typed that.

Title: [SOLVED]Found Bug in r1020
Post by: Steely Ann on October 03, 2007, 07:43:41 am

@imperiumZero

Golly gosh & gee gibbly wilickers, I never would have guessed!