Screenshot naming + gpp1 patch

[A Spork]

Whatever, still makes more sense to me to have
mapnam before nnnn...

[mooseberry]

Whatever, still makes more sense to me to have
mapnam before nnnn...

Whatever, but read the thread you are posting in for it to make more sense.

[A Spork]

What?
how does it not make sense?

[mooseberry]

What?
how does it not make sense?

Hm... Again you should read what people say.

I said read the whole thread carefully to better understand why things are what.

So what are you asking me "how does it not make sense?" for.

(I'll save you time, that was a rhetorical question.)

[A Spork]

Your wording sucks.
And I did read the thread, and I didn't see any reason why mapname has to be last.

[mooseberry]

Your wording sucks.
And I did read the thread, and I didn't see any reason why mapname has to be last.

[UniqPhoeniX]

<date>-0000-atcs
<date>-0001-tremor
<date>-0002-atcs
is better than
<date>-atcs-0000
<date>-atcs-0002
<date>-tremor-0001

[David]

Give them all random junk names, and make a lots of text files all indexed different ways.  Or could make tons and tons of symlinks to make everyone happy.  Or a cvar to let you choose it.  Or do whatever you want safe in the knowledge no one will care enough to submit a rival patch.

[UniqPhoeniX]

Or wait until Tremfusion adds a cvar containing date and time (maybe game time too ).

[Paradox]

Why not just mapname/yyyy-mm-dd.jpg?

[David]

Because then I have to go through a stack of folders to find all of todays shots.

[Ingar]

mapname can't be done because I have to be able to check if a file with a certain number already exists.
I can't use wildcards.

In any case, I cleaned up the patch some more, format stays the same (yyyymmdd-nnnn) but the number resets to 0
on date changes. Demos and videos now use the same naming convention. (I did not change the autorecord demo names).

http://ingar.satgnu.net/tremulous/files/tremulous-gpp1-screenshot_timestamp3.patch

[Thorn]

How many Ingar's does it take to change a screenshot?

[David]

Six.  One to write the patch and 5 to fight off the ravaging hordes.

[gimhael]

mapname can't be done because I have to be able to check if a file with a certain number already exists.
I can't use wildcards.

Wouldn't it make things alot simpler if you just add an archived cvar that holds the date and number of the last screenshot/avi ? Then you don't need to check for existing files at the start, you just continue where you last stopped.

[Ingar]

mapname can't be done because I have to be able to check if a file with a certain number already exists.
I can't use wildcards.

Wouldn't it make things alot simpler if you just add an archived cvar that holds the date and number of the last screenshot/avi ? Then you don't need to check for existing files at the start, you just continue where you last stopped.

The last used number is stored in a static int but it still has to scan the first time. It seems a bit overkill
to make it more complicated 

How many Ingar's does it take to change a screenshot?

Six.  One to write the patch and 5 to fight off the ravaging hordes.

I have an infinite number of scary monkeys.

[Lakitu7]

So is this now done, tested, and ready to go in, with people generally happy about the results?

[Liskey]

Silence means consent - so it must be all good :-)

But since I'm snowed in and bored, I'll ask why would wildcards even be mentioned as an issue.  Don't you need to read all the filenames anyway in order to find the latest?  Just parse out the date and sequence number and ignore the rest -- it makes no difference how filenames are formatted or what else they contain.

Code: [Select]

nextn = 0
today = current_date()
while (fname = readdir(dir)) {
  if (parse_date(fname) == today) {
     if (n=parse_nnnn(fname) >= nextn) nextn = n
  }
}
nextn += 1
 

[Winnie the Pooh]

Ingar has become a developer?

[mooseberry]

What are you talking about?

[Winnie the Pooh]

What are you talking about?

I'm talking about Ingar's work going straight into the official Final.

So is this now done, tested, and ready to go in, with people generally happy about the results?

[mooseberry]

What are you talking about?

I'm talking about Ingar's work going straight into the official Final.

So is this now done, tested, and ready to go in, with people generally happy about the results?

I don't think/didn't know he is official dev, (although I could be wrong for sure) but this is open source, so anyone can create something useful, and "anything" could "potentially" end up being included in 1.2.

[gimhael]

Silence means consent - so it must be all good :-)

But since I'm snowed in and bored, I'll ask why would wildcards even be mentioned as an issue.  Don't you need to read all the filenames anyway in order to find the latest?  Just parse out the date and sequence number and ignore the rest -- it makes no difference how filenames are formatted or what else they contain.

Code: [Select]

nextn = 0
today = current_date()
while (fname = readdir(dir)) {
  if (parse_date(fname) == today) {
     if (n=parse_nnnn(fname) >= nextn) nextn = n
  }
}
nextn += 1
 

Ingar keeps the current file number in a variable, but the variable is lost when you quit and restart tremulous, so it has to scan the existing files to find the highest existing number. After the first screenshot it's just a matter of incrementing a counter.

An other possibility to fix this is to keep the counter value over restarts by storing it in the autogen.cfg.

[Liskey]

Yes of course, he explained all that.

mapname can't be done because I have to be able to check if a file with a certain number already exists. I can't use wildcards.

That was the question - mapname can certainly be included in filenames, there is no reason to use wildcards, and you can check if a file already exists using readdir.

[Ingar]

What are you talking about?

I'm talking about Ingar's work going straight into the official Final.

So is this now done, tested, and ready to go in, with people generally happy about the results?

I don't think/didn't know he is official dev, (although I could be wrong for sure) but this is open source, so anyone can create something useful, and "anything" could "potentially" end up being included in 1.2.

Sorry for the somewhate late response, but I still wanted to clear this up:

I am not an official developer, but I knew how to write code before I could make maps.
When there's something about a program that bothers me, I sometimes take the time to
correct it, make a patch and offer it to the developers. I already did this for a lot
of programs, not just tremulous.

In general, developers tend to pay more attention to patches than to random suggestions.