patch: non modal "server has to many xxx players"

[rasz_pl]

follow up tp http://tremulous.net/phpBB2/viewtopic.php?p=12345#12345

if cg_disableWarningDialogs=1 shows only small info in chat window without modal popup forcing you to press OK.
It looks like someone forgot to add few lines, fixed now :

--- cg_servercmds.c   2006-07-17 19:03:53.000000000 +0200
+++ cg_servercmds.c  2006-07-19 14:31:35.000000000 +0200
@@ -584,15 +584,27 @@
     case MN_H_ARMOURY:  trap_SendConsoleCommand( "menu tremulous_humanarmoury\n" ); break;

     case MN_A_TEAMFULL:
-      trap_Cvar_Set( "ui_dialog", "The alien team has too many players. Please wait until "
+      if( !cg_disableWarningDialogs.integer )
+      {
+       trap_Cvar_Set( "ui_dialog", "The alien team has too many players. Please wait until "
                                   "slots become available or join the human team." );
-      trap_SendConsoleCommand( "menu tremulous_alien_dialog\n" );
+       trap_SendConsoleCommand( "menu tremulous_alien_dialog\n" );
+      }
+      else
+        CG_Printf( "The alien team has too many players\n" );
+
       break;

     case MN_H_TEAMFULL:
-      trap_Cvar_Set( "ui_dialog", "The human team has too many players. Please wait until "
+      if( !cg_disableWarningDialogs.integer )
+      {
+       trap_Cvar_Set( "ui_dialog", "The human team has too many players. Please wait until "
                                   "slots become available or join the alien team." );
-      trap_SendConsoleCommand( "menu tremulous_human_dialog\n" );
+       trap_SendConsoleCommand( "menu tremulous_human_dialog\n" );
+      }
+      else
+        CG_Printf( "The human team has too many players\n" );
+
       break;

     case MN_H_NOROOM:

[tjw]

You should probably create a bug report for this and attach your patch to it:

http://bugzilla.icculus.org/

The patch should be 'svn diff' from the top of the source tree.

[rasz_pl]

https://bugzilla.icculus.org/show_bug.cgi?id=2786
https://bugzilla.icculus.org/show_bug.cgi?id=2787

is it ok ?

[tjw]

https://bugzilla.icculus.org/show_bug.cgi?id=2786
https://bugzilla.icculus.org/show_bug.cgi?id=2787

is it ok ?

Sorry, I meant from inside of trunk/ when I said "the top of the source tree".

Also, it works better to click on "Create a New Attachement" and upload the patch as an attachment.  That way Timbo doesn't have to copy/paste from HTML and if you need to update your patch for the same bug, it's easy to upload a new attachment and there's a checkbox for each existing attachment that lets you idicate that the new one is a replacement.

For an example, see one of of the other bugs which has attachements:
https://bugzilla.icculus.org/show_bug.cgi?id=2758

[rasz_pl]

ok, better now?
BTW diff view looks distorted  in Opera
http://img529.imageshack.us/my.php?image=screenshotpa8.png
how does it look in other browsers?

[next_ghost]

BTW diff view looks distorted  in Opera
http://img529.imageshack.us/my.php?image=screenshotpa8.png
how does it look in other browsers?

No problem in Firefox. Report bug to Bugzilla Bugzilla

[rasz_pl]

No problem in Firefox. Report bug to Bugzilla Bugzilla

haha funny, i'l try in Opera forums first

[dispater]

follow up tp http://tremulous.net/phpBB2/viewtopic.php?p=12345#12345

if cg_disableWarningDialogs=1 shows only small info in chat window without modal popup forcing you to press OK.
It looks like someone forgot to add few lines, fixed now :

--- cg_servercmds.c   2006-07-17 19:03:53.000000000 +0200
+++ cg_servercmds.c  2006-07-19 14:31:35.000000000 +0200
@@ -584,15 +584,27 @@
     case MN_H_ARMOURY:  trap_SendConsoleCommand( "menu tremulous_humanarmoury\n" ); break;

     case MN_A_TEAMFULL:
-      trap_Cvar_Set( "ui_dialog", "The alien team has too many players. Please wait until "
+      if( !cg_disableWarningDialogs.integer )
+      {
+       trap_Cvar_Set( "ui_dialog", "The alien team has too many players. Please wait until "
                                   "slots become available or join the human team." );
-      trap_SendConsoleCommand( "menu tremulous_alien_dialog\n" );
+       trap_SendConsoleCommand( "menu tremulous_alien_dialog\n" );
+      }
+      else
+        CG_Printf( "The alien team has too many players\n" );
+
       break;

     case MN_H_TEAMFULL:
-      trap_Cvar_Set( "ui_dialog", "The human team has too many players. Please wait until "
+      if( !cg_disableWarningDialogs.integer )
+      {
+       trap_Cvar_Set( "ui_dialog", "The human team has too many players. Please wait until "
                                   "slots become available or join the alien team." );
-      trap_SendConsoleCommand( "menu tremulous_human_dialog\n" );
+       trap_SendConsoleCommand( "menu tremulous_human_dialog\n" );
+      }
+      else
+        CG_Printf( "The human team has too many players\n" );
+
       break;


     case MN_H_NOROOM:

ok this lok snice but ihave a question where do i place this?

[stahlsau]

Sry to say but...if you don't know it, you don't need it

[next_ghost]

ok this lok snice but ihave a question where do i place this?

Code: [Select]

$ svn checkout svn://svn.icculus.org/tremulous/trunk/
$ cd trunk/src/game
$ patch <rasz.patch
$ cd ../..
$ make

If you don't know how to do that or why each line contains '$', you don't need this.

[PHREAK]

Nice one razs!

[dispater]

iknow its a svn patch but the thing is ikant find ur and im a noob of course but could u actually help me install it? idi went to the site and looked for it but its not there

[kevlarman]

iknow its a svn patch but the thing is ikant find ur and im a noob of course but could u actually help me install it? idi went to the site and looked for it but its not there

the instructions next_ghost gave you are as simple as they can get (this doesn't mean that they are simple), if you don't understand them as they are, we won't be able to make it any clearer to you.

[err]

nice rasz, cant wait till this patch makes it into codebase. imho all modal dialogs should be disabled by default.

[Stof]

nice rasz, cant wait till this patch makes it into codebase. imho all modal dialogs should be disabled by default.

All modal dialogs should be removed forever.

[dispater]

ohh srry iforgot to mention my Os. my Os is windows Xp. is that why i kant get the thing to work?

[next_ghost]

ohh srry iforgot to mention my Os. my Os is windows Xp. is that why i kant get the thing to work?

Yes, that's one of the causes. Get a real OS or at least Cygwin

[dispater]

ohh ok well no thnkx not here to start a OS war...so its a lunix file for svn...ok well well thnkx 4 da help

[rasz_pl]

ohh ok well no thnkx not here to start a OS war...so its a lunix file for svn...ok well well thnkx 4 da help

its the patch for qvm file, it should be in next version .. but its not even in SVN .. so ...