Pages: [1]   Go Down

Author Topic: security fix backport  (Read 9570 times)

tjw

  • Posts: 210
  • Turrets: +10/-0
security fix backport
« on: June 12, 2006, 05:50:34 pm »
http://trem.tjw.org/backport/

I've backported some engine fixes to the 1.1.0 tremulous client:

* cl_guid (because I'm a shameless self promoter)
https://bugzilla.icculus.org/show_bug.cgi?id=2672

* May 8, 2006 security fix for COM_StripExtension()
http://lists.grok.org.uk/pipermail/full-disclosure/2006-May/045906.html

* WinXP SP2 NX-extension fix
https://bugzilla.icculus.org/show_bug.cgi?id=2683

For security reasons, you should probably use these binaries if you play on untrusted servers.

Even though these are tested you should still save a backup of your original just in case.
Logged

Chojin

  • Posts: 96
  • Turrets: +0/-0
    • http://wraths.dyndns.org
security fix backport
« Reply #1 on: June 13, 2006, 10:30:20 am »
Great ! :D

For all german speaking I mirrored your code here and I'll try to keep it up to date.

Thanks Tony.
Logged

tjw

  • Posts: 210
  • Turrets: +10/-0
security fix backport
« Reply #2 on: June 27, 2006, 05:55:09 pm »
http://trem.tjw.org/backport/

The binaries built today (June 27, 2006) now include the security fix for:
http://www.derkeiler.com/Mailing-Lists/Full-Disclosure/2006-06/msg00112.html
Logged

Chojin

  • Posts: 96
  • Turrets: +0/-0
    • http://wraths.dyndns.org
security fix backport
« Reply #3 on: June 28, 2006, 09:59:58 am »
Thanks, Tony  :D

Mirrored it is.
Logged

tjw

  • Posts: 210
  • Turrets: +10/-0
security fix backport
« Reply #4 on: June 29, 2006, 08:13:17 pm »
I've added the Mac version here too since the last full install Mac build I made (20060625) was accidentally lacking the latest June 2, 2006 fix.
Logged

tjw

  • Posts: 210
  • Turrets: +10/-0
security fix backport
« Reply #5 on: July 13, 2006, 04:09:52 am »
I've updated the windows version to include R1CH's Alt-Tab fix.
Logged

Chojin

  • Posts: 96
  • Turrets: +0/-0
    • http://wraths.dyndns.org
security fix backport
« Reply #6 on: July 13, 2006, 10:33:08 am »
What is the Alt-TAB fix?

Mirrored :D
Logged

[db@]Megabite

  • Posts: 613
  • Turrets: +3/-0
    • http://www.tremulous.info
security fix backport
« Reply #7 on: July 13, 2006, 10:45:15 am »
To get out of the game in windows you had to press ALT-ENTER, which would switch to windowed mode which is quite unhandy.
The patch should enable Tremulous to "ALT-TAB-switch" out of the game into other windows (eg browser, mail, im), just putting it in the background for a moment to do things in other programs.

Not being able to do so is an old crux with Quake-Engine games... this fix is great! ;)

Danny
Logged
url=http://www.tremulous.info][/url]

Chojin

  • Posts: 96
  • Turrets: +0/-0
    • http://wraths.dyndns.org
security fix backport
« Reply #8 on: July 13, 2006, 10:51:04 am »
Oh.. then... I don't like it... I crouch with alt and zoom with tab! I'll land on the desktop quite often :(
Logged

Chojin

  • Posts: 96
  • Turrets: +0/-0
    • http://wraths.dyndns.org
security fix backport
« Reply #9 on: July 13, 2006, 12:11:01 pm »
Yes, the alt-tab menu shows up.. hmm... TJW, could you make it an option maybe? ui_alttab or something like that?
Logged

rasz_pl

  • Guest
security fix backport
« Reply #10 on: July 13, 2006, 03:55:42 pm »
and what about linux? does alt-tabbed windows tem eat 99% of CPU like windowed?
Logged

tjw

  • Posts: 210
  • Turrets: +10/-0
security fix backport
« Reply #11 on: July 14, 2006, 05:28:01 am »
Quote from: "Chojin"
Yes, the alt-tab menu shows up.. hmm... TJW, could you make it an option maybe? ui_alttab or something like that?


You can toggle this in the newest build with the win_allowAltTab cvar.

Also this build supports switching to your normal desktop resolution/depth when you Alt-Tab.

Let me know if this isn't working for anyone.  I'm trying to get this into ioquake3.
Logged

tjw

  • Posts: 210
  • Turrets: +10/-0
security fix backport
« Reply #12 on: July 14, 2006, 05:54:48 am »
Quote from: "rasz_pl"
and what about linux? does alt-tabbed windows tem eat 99% of CPU like windowed?


There is no Alt-Tab equiv in X11.  It's left up to the window manager so doing this in the SDL side would probably be hackish at best.

It still uses full CPU when minimized.  R1CH has a potential fix for this too, but I'm just trying to get the Alt-Tab thing working and tested atm so I haven't added it yet.
Logged

stahlsau

  • Posts: 160
  • Turrets: +1/-1
security fix backport
« Reply #13 on: July 14, 2006, 11:37:09 am »
there is a little program named "etswitch" which does the job quite fine. Just google about it.
Logged

rasz_pl

  • Guest
security fix backport
« Reply #14 on: July 14, 2006, 01:43:40 pm »
Quote from: "stahlsau"
there is a little program named "etswitch" which does the job quite fine. Just google about it.


found it http://hem.bredband.net/b400150/
but it doesnt fix 99% CPU utilization :(
Logged

Paradox

  • Posts: 2612
  • Turrets: +253/-250
    • Paradox Designs
security fix backport
« Reply #15 on: July 14, 2006, 05:05:07 pm »
The alt tab fix is a godsend, it even prevents my gamma from messing up the calibration of my display, but i have noticed a few bugs. The textures seem to mess up at times, making me feel like the game character has taken LSD:
Psychadelic Basalisk
Crazy Tesla Coils
Messed up luci
Dance Floor
Logged

∧OMG ENTROPY∧

tjw

  • Posts: 210
  • Turrets: +10/-0
security fix backport
« Reply #16 on: July 14, 2006, 05:20:05 pm »
Quote from: "Paradox"
The alt tab fix is a godsend, it even prevents my gamma from messing up the calibration of my display, but i have noticed a few bugs. The textures seem to mess up at times, making me feel like the game character has taken LSD:
Psychadelic Basalisk
Crazy Tesla Coils
Messed up luci
Dance Floor


And this always happens when switching back to Trem after it was minimized?  I've seen similar screenshots that were unrelated to the alt-tab thing (just a hot video card).
Logged

rasz_pl

  • Guest
security fix backport
« Reply #17 on: July 14, 2006, 07:29:29 pm »
I'v had a psychedelic larmour yesterday. Linux so it might not be related.
Logged

Paradox

  • Posts: 2612
  • Turrets: +253/-250
    • Paradox Designs
security fix backport
« Reply #18 on: July 14, 2006, 08:30:23 pm »
It happens on my linux box and my windows box.

And it aint a card problem, the cooling system i have reported a normal temp.
Logged

∧OMG ENTROPY∧

[EVIL]Unknown

  • Posts: 263
  • Turrets: +1/-1
    • http://www.evil-clan.com
security fix backport
« Reply #19 on: July 14, 2006, 08:49:28 pm »
i havent gotten this in tremulous but i get that with starcraft +broodwar.. i minimize and reopen window sometimes i get funky colors and wierd textures...maybe same cause?? ill google problem for starcraft...might be related
Logged
url=http://userbars.org][/url]

tjw

  • Posts: 210
  • Turrets: +10/-0
security fix backport
« Reply #20 on: July 14, 2006, 09:58:14 pm »
Quote from: "Paradox"
It happens on my linux box and my windows box.

And it aint a card problem, the cooling system i have reported a normal temp.


What are the cards in each (make/model/RAM)?
Logged

rasz_pl

  • Guest
security fix backport
« Reply #21 on: July 14, 2006, 10:18:11 pm »
mine GF4 4400 64mb
Logged

Paradox

  • Posts: 2612
  • Turrets: +253/-250
    • Paradox Designs
security fix backport
« Reply #22 on: July 14, 2006, 11:56:16 pm »
ATI All in Wonder 9000
Logged

∧OMG ENTROPY∧

Lakitu7

  • Tremulous Developers
  • *
  • Posts: 1002
  • Turrets: +120/-73
security fix backport
« Reply #23 on: July 15, 2006, 02:15:44 pm »
If it's an easy fix, could you possibly fix sort-by-ping in the internal server browser?
Logged

Chojin

  • Posts: 96
  • Turrets: +0/-0
    • http://wraths.dyndns.org
security fix backport
« Reply #24 on: July 17, 2006, 08:37:38 pm »
Quote
You can toggle this in the newest build with the win_allowAltTab cvar.

Also this build supports switching to your normal desktop resolution/depth when you Alt-Tab.

Let me know if this isn't working for anyone. I'm trying to get this into ioquake3.


Great, thanks a lot, Tony :) Works like a charm. I was pretty worried I would have to do without your fixes. Tried it on 2 computers. The one with win_allowAltTab 1 even has desktop resolution and brightness restored.

Now there is one weird thing on the computer with win_allowAltTab 0: As I said i crouch with ALT and zoom with TAB. I have to zoom first, then crouch. Crouching first won't zoom. But it has always been like that in the original client. Nothing you invented ;)
Logged

Great&GentleOrangeOfG

  • Posts: 20
  • Turrets: +0/-0
security fix backport
« Reply #25 on: July 19, 2006, 08:15:33 pm »
Problem!

It seems that the tjw backport executable runs at a lower fps than the original. It's not just me with this problem; I tried to make someone an admin but he didn't want the executable with GUID because of FPS issues.
Logged

tjw

  • Posts: 210
  • Turrets: +10/-0
security fix backport
« Reply #26 on: July 19, 2006, 08:41:59 pm »
Quote from: "Great&GentleOrangeOfG"
Problem!

It seems that the tjw backport executable runs at a lower fps than the original. It's not just me with this problem; I tried to make someone an admin but he didn't want the executable with GUID because of FPS issues.


I seriously doubt any change I have made has any effect on FPS (although anything is possible).  Can you give any reproducable steps that show this?
Logged

Great&GentleOrangeOfG

  • Posts: 20
  • Turrets: +0/-0
security fix backport
« Reply #27 on: July 19, 2006, 09:09:21 pm »
Go to nexus6's yellow hallway (just before one of the stairs to alien base) and shoot a lot of graphic intensive weapons (pulse rifle, lucy, flamer). The fps might be lower when using your binary than when using normal binary. As far as I remember, this should reproduce the problem.

Also try asking ExistentialRisk if you see him. The FPS issues he had caused him to change back to the original binary. (I'm not sure it had any real effect for me, since I didn't do a very objective test. In hindsight I should've done more testing before posting. Sorry about that.)
Logged
Pages: [1]   Go Up