Author Topic: "Avenger"'s builds (Read 64452 times)

Undeference · « **on:** February 06, 2007, 12:30:17 am »

Since Risujin decided to base his new game.qvm on my code and people have begun to confuse his builds with mine, I thought it might be appropriate to create a separate thread for mine.

Today (21 March 2007) I released a build against svn 912. This build is compatible with stock Tremulous 1.1.0 clients. You can download it at ~~mkpdev.googlepages.com~~. All of the deviations from base svn are detailed in the README and will not be listed here (who really wants a page-long list anyway?). If you just want a bunch of cool features, this might not be for you.

If you find bugs with my builds, this is the place to report them (or by PM). If it is a bug with Risujin's build, the Risujin/Avenger game QVM thread is probably the place to report it.

[Edit: Fixed links that were broken from phpBB2->SMF.]
[Edit: Change links with broken redirect.]

vcxzet · « **Reply #1 on:** February 06, 2007, 12:34:20 am »

maybe he should remove avenger title from the builds
maybe : risujin's server only

Undeference · « **Reply #2 on:** February 06, 2007, 12:38:36 am »

Eh, I don't really care, as long as people don't blame me for Risujin's bugs

(just my own). Since some people still call it "Balance Lite", I think renaming it again would just make people that much more confused.

Risujin · « **Reply #3 on:** February 06, 2007, 01:21:01 am »

Quote from: "Undeference"

Eh, I don't really care, as long as people don't blame me for Risujin's bugs (just my own). Since some people still call it "Balance Lite", I think renaming it again would just make people that much more confused.

Technically its just your patch with !layout, \share, and some other minor stuff in it and personally I'd be more than happy to stop maintaining it. Your patch should have TJW's layout commands in it and since thats the way it's going to be from now on might as well let people get used to it.

Pol · « **Reply #4 on:** February 06, 2007, 06:55:35 pm »

Did you fix the callvote map_restart bug?

Undeference · « **Reply #5 on:** February 07, 2007, 12:08:38 am »

A long time ago. Actually, it's my fault that Risujin's version 3 QVM has that bug. It's what happens when the latest patch you have lying around is several months old :-/

Risujin · « **Reply #6 on:** February 07, 2007, 02:05:46 am »

Quote from: "Undeference"

A long time ago. Actually, it's my fault that Risujin's version 3 QVM has that bug. It's what happens when the latest patch you have lying around is several months old :-/

Can we get a single distribution going here? I don't want to have to make a new "Risujin's Avenger QVM" ... you seem to be missing a few good patches.

Here are the changes I ended up adding, most of these can be disabled with cvars:
-- \share? \donate?
-- g_retribution
-- g_shove that can stack
-- my blaster ckit fix
-- generic flood protection
-- I won't insist on !layout or !slap

I realize there aren't clean patches against SVN879 for most of these changes, I can provide those if you're interested.

Undeference · « **Reply #7 on:** February 07, 2007, 03:08:09 am »

Quote

-- \share? \donate?

I don't like them. With share, I can make stacking all the more effective. With donate, I can practically ensure a win for my team if no one on the other team is as good as me.

Quote

-- g_retribution

I am currently working on a rewrite of player_die that is (hopefully) cleaner and is similar in functionality to retribution.

Quote

-- g_shove that can stack

Is that a serious fix? In Bugzilla?

Quote

-- my blaster ckit fix

That is minor. The only real argument I can think of for having it is that grangers can attack while their build counter resets.

Quote

-- generic flood protection

There are problems with any "flood prevention" system and I'm not sure which way I'd want to go if I were in a position to choose. Luckily, there hasn't been much need for it to date. (Of course we're all waiting for the day when human moderators can be replaced, but I think that's still some time in the future.)

Quote

I realize there aren't clean patches against SVN879 for most of these changes, I can provide those if you're interested.

If you want to write patches for my build specifically (and I can't really imagine why unless perhaps it's to fix a bug specific to my build), don't do it to revision 879. The build is essentially a copy of revision 894 minus some.

vcxzet · « **Reply #8 on:** February 07, 2007, 03:23:23 am »

Quote from: "Undeference"

Quote
-- my blaster ckit fix
That is minor. The only real argument I can think of for having it is that grangers can attack while their build counter resets.

this gave me an idea for tremx
zapping cancel build fire

Odin · « **Reply #9 on:** February 07, 2007, 04:39:31 am »

How about "OMG SUPER QVM".

dodo1122 · « **Reply #10 on:** February 07, 2007, 04:28:36 pm »

Quote from: "Risujin"

Quote from: "Undeference"
A long time ago. Actually, it's my fault that Risujin's version 3 QVM has that bug. It's what happens when the latest patch you have lying around is several months old :-/

Can we get a single distribution going here? I don't want to have to make a new "Risujin's Avenger QVM" ... you seem to be missing a few good patches.

Here are the changes I ended up adding, most of these can be disabled with cvars:
-- \share? \donate?
-- g_retribution
-- g_shove that can stack
-- my blaster ckit fix
-- generic flood protection
-- I won't insist on !layout or !slap

I realize there aren't clean patches against SVN879 for most of these changes, I can provide those if you're interested.

yes plz, i would like to patch them myself

it is pretty hard right now to get it all working together.

dodo

Risujin · « **Reply #11 on:** February 07, 2007, 10:24:11 pm »

Quote from: "Undeference"

Quote
-- \share? \donate?
I don't like them.

This is why I end up having to maintain three different QVMs. You don't like a feature therefore no server operator would ever want it. :x

My philosophy is add it and let the people who end up actually playing it decide (admins in any case).

Quote from: "Undeference"

Quote
-- g_retribution
I am currently working on a rewrite of player_die that is (hopefully) cleaner and is similar in functionality to retribution.

Cleaner how? Its like 10 lines of code. Basically you make a TKer pay their victim.

Quote from: "Undeference"

Quote
-- g_shove that can stack
Is that a serious fix? In Bugzilla?

I just looked at it and the only real difference between my version and SVN is that, in SVN, when you are the larger entity and you jump on top of the smaller one it gets shoved out from under you. So a granger can't ride a dretch.

Quote from: "Undeference"

Quote
-- my blaster ckit fix
That is minor.

One line of code and human builders are a little less defenseless. Add:

Code: [Select]

case WP_BLASTER:
To g_active.c:696 ClientTimerActions()

Quote from: "Undeference"

Quote
-- generic flood protection
There are problems with any "flood prevention" system and I'm not sure which way I'd want to go if I were in a position to choose. Luckily, there hasn't been much need for it to date.

If I were a server op I would love an automatic way to shut up spammers. Takes care of every spam-related server instability automatically (remember \team spam?). Been languishing in bugzilla for ages, I wonder why it hasn't been merged...
https://bugzilla.icculus.org/show_bug.cgi?id=2811

Quote

If you want to write patches for my build specifically (and I can't really imagine why unless perhaps it's to fix a bug specific to my build)

To add all the patches you consistently ignore...

Yarou · « **Reply #12 on:** February 07, 2007, 10:36:36 pm »

If you're compiling a qvm for all-purpose use, you should only include the features which are already standardized, not erroneous commands that are used for entertainment...

Risujin · « **Reply #13 on:** February 07, 2007, 10:40:44 pm »

Quote from: "Yarou"

If you're compiling a qvm for all-purpose use, you should only include the features which are already standardized, not erroneous commands that are used for entertainment...

I can't say this enough: All of these are DISABLED by default.

Yarou, could you possibly set a larger sig? :evil:

Undeference · « **Reply #14 on:** February 08, 2007, 12:54:27 am »

Quote

My philosophy is add it and let the people who end up actually playing it decide (admins in any case).
...
To add all the patches you consistently ignore...

I'm trying not to diverge too much from svn. (That is part of the reason I don't like this being called a "mod".) You may also want to refer to my first post in this thread: "If you just want a bunch of cool features, this might not be for you."
I'm more interested in what happens to Tremulous than this specific build. I am more likely to add a feature to my code if it's in Bugzilla and seems likely to ultimately make it into svn in some form or other.

Quote

in SVN, when you are the larger entity and you jump on top of the smaller one it gets shoved out from under you.

That could be a bug. Why don't you report it?

Quote

Cleaner how? Its like 10 lines of code. Basically you make a TKer pay their victim.

Cleaner by being more straight forward, trying to reduce the distinction between "nice simple happy bouncy human land" and "horribly complex nasty alien land". I also try to reward based on accomplishment more than anything else (and punish team kills and suicides differently).
Your functionality could be duplicated, but I don't know if it would be wanted assuming my changes work as I want them to.

Risujin · « **Reply #15 on:** February 08, 2007, 02:03:40 am »

Quote from: "Undeference"

I'm trying not to diverge too much from svn. (That is part of the reason I don't like this being called a "mod".)

Err... a mod (and yes, this is) thats "not trying to diverge too much"? Yours is the most hacked up version of Trem Ive seen short of Balance/TremX. Thats not a good reason.

Quote from: "Undeference"

Quote
in SVN, when you are the larger entity and you jump on top of the smaller one it gets shoved out from under you.
That could be a bug. Why don't you report it?

Yeah, along with a patch.

Quote from: "Undeference"

Cleaner by being more straight forward, trying to reduce the distinction between "nice simple happy bouncy human land" and "horribly complex nasty alien land". I also try to reward based on accomplishment more than anything else (and punish team kills and suicides differently).
Your functionality could be duplicated, but I don't know if it would be wanted assuming my changes work as I want them to.

Retribution has nothing to do with recoding "horribly complex nasty alien land". You are reinventing the wheel. :roll:

dodo1122 · « **Reply #16 on:** February 08, 2007, 04:44:46 pm »

dont argue, get coding

this way we would have better qvm's, and less arguing in forums.

dodo

Paradox · « **Reply #17 on:** February 09, 2007, 12:40:36 am »

How about this, a lite qvm, then a mega qvm, mega has everything, lite has basics.

Risujin · « **Reply #18 on:** February 09, 2007, 01:05:15 am »

Quote from: "Paradox"

How about this, a lite qvm, then a mega qvm, mega has everything, lite has basics.

Thats whats so dumb about it. The features we're talking about here are disabled by default ... theres no sense in leaving em out and flooding QVMs left and right... :-?

dodo1122 · « **Reply #19 on:** February 09, 2007, 12:00:57 pm »

well. just do a patch with all the extra features for this qvm and make it public, so then anyone cound just patch it if they want.

dodo

Paradox · « **Reply #20 on:** February 10, 2007, 03:26:29 am »

Quote from: "dodo1122"

well. just do a patch with all the extra features for this qvm and make it public, so then anyone cound just patch it if they want.

How about this, one QVM, with everything, but off by default.

n00b pl0x · « **Reply #21 on:** February 10, 2007, 03:27:28 am »

Quote from: "Paradox"

Quote from: "dodo1122"
well. just do a patch with all the extra features for this qvm and make it public, so then anyone cound just patch it if they want.

How about this, one QVM, with everything, but off by default.

DUDE ARE YOU LIEK A ROCKET SCIENTIST IRL?

Paradox · « **Reply #22 on:** February 10, 2007, 03:28:54 am »

No, just a person who quotes other people's post in my own words in some ways.

n00b pl0x · « **Reply #23 on:** February 10, 2007, 03:29:57 am »

i think everyone has been wanting an idea like this for a while...but most people cant do it and the ones that can are too lazy/busy to do it

-:GoDz:-Devil · « **Reply #24 on:** February 10, 2007, 05:02:29 am »

I don't know if its me, or the patch, but I setup the server and I did everything I am suppose to do, and when it setup I entered the server and admin works great, except for chatting, I could not TeamTalk or Talk at all.

So if there was something I did not patch right someone let me know please.

Thank You

Risujin · « **Reply #25 on:** February 10, 2007, 05:49:15 pm »

Quote from: "Paradox"

How about this, one QVM, with everything, but off by default.

That's what I'm trying to nag Undeference into doing.

Undeference · « **Reply #26 on:** February 11, 2007, 03:09:04 am »

Quote from: "-:GoDz:-Devil"

I don't know if its me, or the patch, but I setup the server and I did everything I am suppose to do, and when it setup I entered the server and admin works great, except for chatting, I could not TeamTalk or Talk at all.

So if there was something I did not patch right someone let me know please.

Thank You

Yikes! Good find.
I fixed it and updated the patch and qvm. If you want to manually fix it, look for

Code: [Select]

  // send it to all the apropriate clients
  for( j = 0; j < level.maxclients; j++ )
  {
    other = &g_entities[ j ];
    G_SayTo( ent, target, mode, color, name, text, prefix );
  }

in src/game/g_cmds.c (line 993 in my copy) and change the 'G_SayTo' line to

Code: [Select]

G_SayTo( ent, other, mode, color, name, text, prefix ); (it was 'target' but should have been 'other').

Quote

Err... a mod (and yes, this is) thats "not trying to diverge too much"? Yours is the most hacked up version of Trem Ive seen short of Balance/TremX. Thats not a good reason.

The difference between svn code and my code is that I include changes that may make it to svn but are not there yet. The better tested a feature or bug fix is, the more likely it is to be included or excluded (depending on the outcome of the testing).
Call it a "development build" if you will, but "mod" gives the wrong impression: that this is just a cool hack-up, more for entertainment than functionality.

Quote

Retribution has nothing to do with recoding "horribly complex nasty alien land". You are reinventing the wheel.

player_die is not related to retribution; retribution relies on player_die
If the wheel needs fixing, it should be fixed. "horribly complex" ~ "broken"

Risujin · « **Reply #27 on:** February 11, 2007, 03:23:44 am »

Quote

"mod" gives the wrong impression: that this is just a cool hack-up, more for entertainment than functionality.

It's a game! It's meant for entertainment.

Quote

"horribly complex" ~ "broken"

If it ain't broken (i.e. not working) don't fix it. But whatever, it's your time not mine. :roll:

Undeference · « **Reply #28 on:** February 11, 2007, 04:11:28 am »

Quote

It's a game! It's meant for entertainment.

I figured it would be more appropriate if I used "entertainment" than "shits and giggles".

Quote

If it ain't broken (i.e. not working)

Coming from you...?

Just because it works don't mean it ain't broke.

Pol · « **Reply #29 on:** February 11, 2007, 10:54:33 am »

Okay now children, split it up.

News:

Author Topic: "Avenger"'s builds (Read 64452 times)

vcxzet

Pol

vcxzet

-:GoDz:-Devil

Pol